-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwanted permissions added by manifest merger because targetSdkVersion is not definied #16
Comments
I will attempt to get to this on the weekend -- my apologies. |
👍 came here to report this. @pawel-marchewka thank you for reporting. |
talklittle
added a commit
to talklittle/cwac-merge
that referenced
this issue
Dec 7, 2014
commonsguy
added a commit
that referenced
this issue
Dec 7, 2014
Addressed in v1.1.0 -- let me know if you encounter further problems. |
Confirmed fixed in v1.1.0. Thank you @commonsguy! |
Yes, it works. Thank you very much for the very fast fix of the problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi.
We use MergeAdapter in one of our application and noticed that APK built with Android Studio/Gradle has more permissions than we declared in our AndroidManifest.xml.
In "...\build\outputs\apk" manifest merger generates files (manifest-merger-[debug|release]-report.txt) with information why and from each element was added to the final manifest. In these files you can see something like below:
which is true because CWAC's manifest doesn't specify minSdkVersion or targetSdkVersion so both defaults to 1.
Steps to reproduce:
It would great if you can specify some minimal targetSdkVersion like "4" to prevent manifest merger from automatically adding permissions which have nothing in common with MergeAdapter :)
Thanks.
The text was updated successfully, but these errors were encountered: