Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improve navigation in DICOM browser tables #1025

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

lassoan
Copy link
Member

@lassoan lassoan commented Feb 17, 2022

DICOM patient/study/series tables use entire selection, so for users they appear as lists, and so users expect that they can use Home/End key to navigate to the top/bottom of the list.

This commit makes Home/End key jumps to top/bottom of the table (the keys did not change the selection before) and makes Tab/Shift+Tab key goes to next/previous table (instead of going to next/previous cell within a row).

Fixes Slicer/Slicer#6078

DICOM patient/study/series tables use entire selection, so for users they appear as lists, and so users expect that they can use Home/End key to navigate to the top/bottom of the list.

This commit makes Home/End key jumps to top/bottom of the table (the keys did not change the selection before) and makes Tab/Shift+Tab key goes to next/previous table (instead of going to next/previous cell within a row).

Fixes Slicer/Slicer#6078
@lassoan lassoan requested a review from pieper February 17, 2022 15:35
@lassoan lassoan self-assigned this Feb 17, 2022
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lassoan lassoan merged commit c506a02 into commontk:master Feb 19, 2022
@lassoan lassoan deleted the dicom-table-home-end-navigation branch February 19, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Allow use of Home and End keys to go to top/end of a list
2 participants