Browser thumbnails #1063
Merged
Browser thumbnails #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow a way to reduce "time to first image" in the DICOM browser and help testing troubleshooting, an image thumbnail is displayed in the DICOM metadata browser window. The thumbnail is only retrieved if the collapsible section is open (to save space and improve performance when accessing large images). Based on ProjectWeek discussion: https://projectweek.na-mic.org/PW35_2021_Virtual/Projects/mpReview/ Co-authored-by: Andras Lasso <lasso@queensu.ca>
The initial direction of the double-arrow button was incorrect (left-to-right instead of right-to-left), as the icon was only updated when the user clicked on it, and not when the checked state was changed by calling `setChecked()`.
After the DICOM metadata viewer window was show maximized and then closed by hitting Escape button: the metadata viewer opened the widget maximized, but the layout inside was much smaller. Applied parts of [this workaround](https://stackoverflow.com/questions/44005852/qdockwidgetrestoregeometry-not-working-correctly-when-qmainwindow-is-maximized) to ensure that the widget size is restored when the window is maximized.
|
I think we should also make this dialog non-modal, but that can be a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds image thumbnail display to the DICOM metadata viewer window:
This pull request replaces the WIP pull request by @pieper - #979 (comment)