Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: follow symlinks in dicom indexing #1066

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

pieper
Copy link
Member

@pieper pieper commented Feb 10, 2023

Enabled by default, but settable as a property.

Fixes #1065

@pieper pieper requested a review from lassoan February 10, 2023 19:17
@pieper
Copy link
Member Author

pieper commented Feb 10, 2023

Confirmed that this works to index a linked directory on mac where previously it had failed to index.

Enabled by default, but settable as a property.

Fixes #1065
@pieper
Copy link
Member Author

pieper commented Feb 20, 2023

@lassoan can you give this a quick review when you have a chance? Exposing the option turned into a lot of small edits.

Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@pieper pieper merged commit 3286ac3 into master Feb 22, 2023
@pieper pieper deleted the 1065-dicom-follow-links branch February 22, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Follow symlinks when indexing dicom
2 participants