BUG: Fix lupdate warnings on translation function calls #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lassoan
reviewed
Feb 15, 2023
Libs/Widgets/ctkSettingsDialog.cpp
Outdated
| @@ -167,11 +167,11 @@ void ctkSettingsDialogPrivate::updateRestartRequiredLabel() | |||
| bool restartRequired = !restartRequiredSettings.isEmpty(); | |||
| if (restartRequired) | |||
| { | |||
| QString header = q->tr( | |||
| QString header = ctkSettingsDialog::tr( | |||
There was a problem hiding this comment.
If not too complicated, remove HTML tags from translatable text.
There was a problem hiding this comment.
Thanks, HTML tags are now separated from the translatable text.
mhdiop
force-pushed
the
translation-function-call-fix
branch
2 times, most recently
from
1d02596
to
04c3dcc
Compare
mhdiop
force-pushed
the
translation-function-call-fix
branch
from
04c3dcc
to
e83aa1e
Compare
lassoan
reviewed
Mar 1, 2023
Libs/Widgets/ctkSettingsDialog.cpp
Outdated
| QString footer = q->tr("</small>"); | ||
| QString header = "<b style=\"color:red\">" + ctkSettingsDialog::tr("Restart required!") + "</b><br>\n<small>"; | ||
| header += ctkSettingsDialog::tr( | ||
| "The application must be restarted to take into account the new values of the following properties:\n" |
There was a problem hiding this comment.
Could you move out the \n from the translatable string?
There was a problem hiding this comment.
Ok, it's done now, thanks !
mhdiop
force-pushed
the
translation-function-call-fix
branch
from
e83aa1e
to
dc6e488
Compare
lassoan
reviewed
Mar 1, 2023
| QString header = "<b style=\"color:red\">" + ctkSettingsDialog::tr("Restart required!") + "</b><br><small>"; | ||
| header += ctkSettingsDialog::tr( | ||
| "The application must be restarted to take into account the new values of the following properties:" | ||
| ); |
There was a problem hiding this comment.
We still need the \n at the end of the header, I just asked for adding it outside the tr() function.
Could you add "\n" to the header after the header += ctkSettingsDialog::tr("The application must be restarted...properties:"); line? Thank you!
There was a problem hiding this comment.
Ah ok I see, the update is done. Thanks.
Qt lupdate tool throws `Cannot invoke tr() like this` warnings when translation function is called using `q->tr(...)`. The problem is that lupdate cannot determine the class name `tr()` is called on and therefore it does not know the translation context. The solution is to spell out the class name in the call, for example `ctkSettingsDialog::tr(...)`. More details are described here: https://github.com/Slicer/SlicerLanguagePacks/blob/main/DevelopersManual.md see Slicer/SlicerLanguagePacks#17 see Slicer/SlicerLanguagePacks#12
mhdiop
force-pushed
the
translation-function-call-fix
branch
from
dc6e488
to
37a6fbd
Compare
lassoan
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt lupdate tool throws
Cannot invoke tr() like thiswarnings when translation function is called usingq->tr(...). The problem is that lupdate cannot determine the class nametr()is called on and therefore it does not know the translation context. The solution is to spell out the class name in the call, for exampleqSlicerScalarVolumeDisplayWidget::tr(...). More details are described here: https://github.com/Slicer/SlicerLanguagePacks/blob/main/DevelopersManual.mdsee Slicer/SlicerLanguagePacks#17
see Slicer/SlicerLanguagePacks#12