ENH: Add layout orientation to ErrorLogDockWidget #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Punzo
force-pushed
the
ErrorLogWidgetLayout
branch
2 times, most recently
from
92cf312
to
ad51b28
Compare
Punzo
changed the title
jcfr
requested changes
Jun 29, 2023
Punzo
force-pushed
the
ErrorLogWidgetLayout
branch
from
94c394c
to
8de0638
Compare
|
@jcfr I have applied the feedback. |
lassoan
reviewed
Jun 29, 2023
ok, I have applied the feedback. |
lassoan
force-pushed
the
ErrorLogWidgetLayout
branch
from
a2bcb66
to
1d8c319
Compare
lassoan
force-pushed
the
ErrorLogWidgetLayout
branch
from
1d8c319
to
612b68e
Compare
- Layout orientation can be configured: it allows better use of available space if the window is very tall or wide (e.g., when in a docking widget). - Added userViewed() signal: it can be used to detect that the user viewed messages. - Home/End keys now jump to first/last message (not to the first/last cell of the current row). - Small cosmetic fix: "All" button height now matches other buttons in the row, regardless of screen resolution. Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Co-authored-by: Andras Lasso <lasso@queensu.ca>
lassoan
force-pushed
the
ErrorLogWidgetLayout
branch
from
612b68e
to
f5fff61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by Slicer/Slicer#7059