Extend the ctkPluginFrameworkLauncher convenience run method to accept cl args #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@espakm @saschazelzer Does this look good for you ? After squashing the commit together, should this be integrated ? Thanks for reviewing. |
| @@ -107,10 +107,11 @@ class CTK_PLUGINFW_EXPORT ctkPluginFrameworkLauncher | |||
| * | |||
| * @param endSplashHandler the block of code to run to tear down the splash | |||
| * screen or <code>null</code> if no tear down is required | |||
| * @param argument the argument passed to the application. May be <code>null</code> | |||
There was a problem hiding this comment.
Instead of "may be null", I suggest: "Default is QVariant()."
|
@jcfr Yes, that's good. I've been using this commit for a while, it works well. |
Previously one either had the choice of using the convenience run method, without having the option of handling command line arguments, or handling startup etc oneself. This change will add an additional parameter to the convenience run method which takes the command line arguments and hands them through.
CJGoch
force-pushed
the
extend-convenience-run-to-hand-through-cl-arguments
branch
from
90d1728
to
2544509
Compare
|
Incorporated hmeines comment and squashed the result. Is there anything left to do? |
|
👍 |
1 similar comment
|
👍 |
jcfr
added a commit
that referenced
this pull request
Nov 4, 2015
…rough-cl-arguments Extend the ctkPluginFrameworkLauncher convenience run method to accept cl args
CJGoch
deleted the
extend-convenience-run-to-hand-through-cl-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously one either had the choice of using the convenience run method,
without having the option of handling command line arguments, or handling
startup etc oneself. This change will add an additional parameter to the
convenience run method which takes the command line arguments and hands
them through.
cc: @saschazelzer