BUG: Fixed warped widgets in ctkVTKSliceView overlay #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default camera for overlay layer in ctkVTKSliceView was a default VTK camera with perspective projection. This caused widgets appear tilted/warped when displayed near the edge of the render window. This was particularly visible in vector text rendered by VTK seed widget (markup fiducials in 3D Slicer).
lassoan
added a commit
to lassoan/SlicerGitSVNArchive
that referenced
this pull request
Jun 21, 2017
Requires integration of "BUG: Fixed warped widgets in ctkVTKSliceView overlay" in CTK (commontk/CTK#720).
|
👍 |
|
I've done some more testing with this patch in Slicer and found issues with placing ruler and ROI annotations. Somehow the mapping between display and world coordinate system is impacted. There were some workarounds in the code, so maybe there were some underlying issues earlier that this change uncovered. I continue to investigate this. |
|
Setting all slice view renderer cameras to use parallel projection solved the issue. Probably the issue is that widget point placer may find a different renderer than the widget's renderer. The behavior is now correct and I cannot spend more time on investigating how this could be made more robust/future-proof. |
|
That seems reasonable to me. Thanks Andras. |
jcfr
pushed a commit
to Slicer/SlicerGitSVNArchive
that referenced
this pull request
Jun 22, 2017
Warping of markup fiducial labels was caused by using perspective projection in overlay renderer's camera. See details in commontk/CTK#720. By switching to parallel projection, default scaling of widgets have to be adjusted, and all other renderers should also use parallel projection to make point placing for widgets invariant to the renderer that is picked. git-svn-id: http://svn.slicer.org/Slicer4/trunk@26107 3bd1e089-480b-0410-8dfb-8563597acbee
fedorov
pushed a commit
to fedorov/Slicer-legacy
that referenced
this pull request
Jun 24, 2017
Warping of markup fiducial labels was caused by using perspective projection in overlay renderer's camera. See details in commontk/CTK#720. By switching to parallel projection, default scaling of widgets have to be adjusted, and all other renderers should also use parallel projection to make point placing for widgets invariant to the renderer that is picked. git-svn-id: http://svn.slicer.org/Slicer4/trunk@26107 3bd1e089-480b-0410-8dfb-8563597acbee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default camera for overlay layer in ctkVTKSliceView was a default VTK camera with perspective projection.
This caused widgets appear tilted/warped when displayed near the edge of the render window.
This was particularly visible in vector text rendered by VTK seed widget (markup fiducials in 3D Slicer).
Before the fix:
After the fix:
