ENH: Add checkBoxControlsButtonToggleState property to ctkCheckablePushButton #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
requested changes
Apr 20, 2020
Sunderlandkyl
force-pushed
the
ctkCheckablePushButton_checkBoxControlsButtonToggleState
branch
2 times, most recently
from
f3a7c2d
to
6aefd7d
Compare
|
Thanks @jcfr. Comments addressed and test updated. |
lassoan
approved these changes
Apr 20, 2020
…shButton If checkBoxControlsButtonToggleState is enabled then clicking the checkbox also makes the button pushed (for user's convenience) and unpushing the button makes it unchecked, too (to avoid the ambiguous state when the button's checkbox is checked but the button is not pressed down). The property is disabled for now to preserve the current behavior (for backward compatibility). Co-authored-by: Kyle Sunderland <sunderlandkyl@gmail.com>
Sunderlandkyl
force-pushed
the
ctkCheckablePushButton_checkBoxControlsButtonToggleState
branch
from
6aefd7d
to
fadf76b
Compare
Sunderlandkyl
deleted the
ctkCheckablePushButton_checkBoxControlsButtonToggleState
branch
jcfr
pushed a commit
to Slicer/Slicer
that referenced
this pull request
Apr 21, 2020
List of changes:
```
$ git shortlog 27bc11d..8ec9136
Jean-Christophe Fillion-Robin (1):
COMP: Fix Qt4 build adding fallback implementation for qUtf8Printable() (commontk/CTK#909)
Kyle Sunderland (1):
ENH: Add checkBoxControlsButtonToggleState property to ctkCheckablePushButton (commontk/CTK#908)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If checkBoxControlsButtonToggleState is enabled then clicking the checkbox also makes the button pushed (for user's convenience) and unpushing the button makes it unchecked, too (to avoid the ambiguous state when the button's checkbox is checked but the button is not pressed down).
The property is disabled for now to preserve the current behavior (for backward compatibility).
Co-authored-by: Kyle Sunderland sunderlandkyl@gmail.com
Replaces #899