BUG: Fix DICOM table defined stylesheet messing up use with palette #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
approved these changes
Jul 29, 2020
|
@lassoan If you want to merge this for me (I'm unable to), I can then issue a commit to my corresponding Slicer dark mode PR that will update the CTK hash. |
@jamesobutler I just added you to the https://github.com/orgs/commontk/teams/team-ctk team, this will give you write access to CTK, AppLauncher and few other repositories. cc: @commontk/team-ctk , for reference prior contributions of @jamesobutler are listed here |
|
Thanks JC! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching style using palettes as part of some work in 3D Slicer to implement Light and Dark modes this defined stylesheet in the ctkDICOMTableManager was messing things up by not changing when the style in 3D Slicer was dynamically changed after startup. It was flip-flopping and using the previous palette color instead of the currently specified one. Removing this stylesheet solves this issue.
Note to see these exact results in Slicer, one must use the latest of Slicer/Slicer#4993.
cc: @lassoan