Adding support for VTK 9.0 #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
approved these changes
Oct 10, 2020
|
@kraehlit It would be great if you could make one improvement: centralize setting of default surface format. We know that this code will have to be kept tuned as VTK and Qt is upgraded and it is Qt, VTK, and operating system dependent. Could you add a helper function that sets up default surface format and use that single line everywhere (instead of repeating a somewhat complex logic at many places)? Thank you! |
|
@lassoan I have changed the code and centralize the setting of the default surface format as you requested. |
|
Thanks. I will integrate shortly 🙏 |
Co-authored-by: Tobias Krähling <Tobias.Kraehling@SemiByte.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support build with VTK 9.0
In VTK 9.0 QVTKOpenGLWidget is deprecated and should be replaced by QVTKOpenGLNativeWidget. Additional library references are required in VTK/Core and VTK/Widget.
Changes tested under Win10 with external build VTK 9.0.1.