BUG: Remove assert from matrix widget that flooded application log #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each time a ctkMatrixWidget was shown, a series of errors about width and height mismatch flooded the log, making it harder to read. Since these mismatches do not seem to have any consequence on function, it seems to be more advantageous to remove the asserts.
|
A block of warnings like this appeared on each first show of matrix widget: |
|
Thanks @pieper ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time a ctkMatrixWidget was shown, a series of errors about width and height mismatch flooded the log, making it harder to read. Since these mismatches do not seem to have any consequence on function, it seems to be more advantageous to remove the asserts.