Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix configure error on Linux with DCMTK_ENABLE_CXX11 enabled
Configuring on Linux with DCMTK_ENABLE_CXX11 enabled generates an error in the configuration step: CMake Error at CMake/GenerateDCMTKConfigure.cmake:1252 (MESSAGE): ... /path/to/dcmtk/config/tests/../math.cc:88:12: error: '::isnan' has not been declared return ::isnan(f); One way around this is to ensure that the preferred std::isnan() function is used instead. This commit fixes the following error in the check for that function by specifying the double overload: FAILED: CMakeFiles/cmTC_62c88.dir/CheckSymbolExists.cxx.o /path/to/dcmtk-build/CMakeTmp/CheckSymbolExists.cxx:29:11: error: statement cannot resolve address of overloaded function std::isnan;return 0;
- Loading branch information
c9ccd45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msmolens did you submit this patch to the DCMTK team?
cc: @michaelonken
c9ccd45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fedorov Thanks, yes, the DCMTK team is aware of the patch: https://github.com/msmolens/DCMTK/commit/c9ccd45212cb542d78201995951fbcfb416f8b16#commitcomment-23467725
c9ccd45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Jan is responsible for the related code and returns from vacaction next week AFAIK)
c9ccd45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@jcfr please let me know how you want to proceed. I would like to update DCMTK to this commit: http://git.dcmtk.org/?p=dcmtk.git;a=commit;h=998058d4b1bff1066beb5caa01a90f7476ab8f34. Will you rebase this patched branch?
c9ccd45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fedorov All set. See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=26274
c9ccd45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jcfr