Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload theme when changed #114

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Reload theme when changed #114

merged 1 commit into from
Jul 22, 2016

Conversation

gdamjan
Copy link
Contributor

@gdamjan gdamjan commented Jul 22, 2016

ThemeInfo got a new pricate entry to remember the file it loaded, and a new method reload() that calls load() with
the original filename.

@gdamjan
Reload theme when changed
5ae7f6a 
ThemeInfo got a new pricate entry to remember the file it loaded, and a new method `reload()` that calls `load()` with
the original filename.
@gdamjan
Copy link
Contributor Author

gdamjan commented Jul 22, 2016

ps.
I'm failry a newbie with Qt/C++ so, is d.filePath = filePath; ok, or I need a copy of the QString?

@jpnurmi
Copy link
Member

jpnurmi commented Jul 22, 2016

is d.filePath = filePath; ok, or I need a copy of the QString?

Looks good. This actually makes a (shallow) copy of the string.

@jpnurmi jpnurmi merged commit 33a3a8c into communi:master Jul 22, 2016
@gdamjan gdamjan deleted the reload-theme branch July 22, 2016 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdamjan @jpnurmi