Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fs 4064 allocation association table #481

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

ksp37-dluhc
Copy link
Contributor

Change description

Added allocation association table as a prerequisite for assigning assessors to assessments.

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

N/A (manually tests upgrade / downgrade of alembic revision)

Screenshots of UI changes (if applicable)

NarenderRajuB
NarenderRajuB previously approved these changes Jun 17, 2024
Copy link
Contributor

@NarenderRajuB NarenderRajuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adam-W1
Copy link
Contributor

Adam-W1 commented Jun 18, 2024

Looks good. Only thought is..
Are we planning on allowing user-assessment deallocation ? If so, do would we need some sort of ‘active’ flag in this table (similar to the associated flag in tag_associations)? It might even be worth including it because i predict de-allocations being a desired feature at some point.

@ksp37-dluhc
Copy link
Contributor Author

Looks good. Only thought is.. Are we planning on allowing user-assessment deallocation ? If so, do would we need some sort of ‘active’ flag in this table (similar to the associated flag in tag_associations)? It might even be worth including it because i predict de-allocations being a desired feature at some point.

(Discussed this in standup and agreed this is the desirable approach. Posting here to keep a record).

NarenderRajuB
NarenderRajuB previously approved these changes Jun 24, 2024
Copy link
Contributor

@NarenderRajuB NarenderRajuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksp37-dluhc ksp37-dluhc merged commit 57daead into main Jun 24, 2024
14 checks passed
@ksp37-dluhc ksp37-dluhc deleted the FS-4064-allocation-association-table branch June 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants