forked from googleapis/api-linter
-
Notifications
You must be signed in to change notification settings - Fork 0
/
forbidden_types.go
43 lines (39 loc) · 1.39 KB
/
forbidden_types.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
// Copyright 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package aip0141
import (
"fmt"
"bitbucket.org/creachadair/stringset"
"github.com/commure/api-linter/lint"
"github.com/commure/api-linter/locations"
"github.com/commure/api-linter/rules/internal/utils"
"github.com/jhump/protoreflect/desc"
)
var forbiddenTypes = &lint.FieldRule{
Name: lint.NewRuleName(141, "forbidden-types"),
LintField: func(f *desc.FieldDescriptor) []lint.Problem {
nope := stringset.New("fixed32", "fixed64", "uint32", "uint64")
if typeName := utils.GetTypeName(f); nope.Contains(typeName) {
// Preserve original intent w/r/t 32-bit vs. 64-bit.
want := "int" + typeName[len(typeName)-2:]
return []lint.Problem{{
Message: fmt.Sprintf("Use %q instead of %q.", want, typeName),
Suggestion: want,
Descriptor: f,
Location: locations.FieldType(f),
}}
}
return nil
},
}