Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/update requested gwas.sif binaries #214

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Add/update requested gwas.sif binaries #214

merged 5 commits into from
Dec 14, 2023

Conversation

espenhgn
Copy link
Contributor

Fixes #213
Fixes #212
Fixes #211
Fixes #209
Fixes #205

Changes proposed in this pull request:

  • Adds GNU debugger (gdb), SNPTEST and LDAK
  • Updates qctool, METAL
  • Rebuilt gwas.sif
  • Updated tests

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn espenhgn added the enhancement New feature or request label Dec 12, 2023
@espenhgn espenhgn changed the title Espenhgn/issue209 Add/update requested gwas.sif binaries Dec 12, 2023
@espenhgn espenhgn requested a review from ofrei December 12, 2023 21:58
@espenhgn espenhgn mentioned this pull request Dec 13, 2023
Closed
ofrei
ofrei approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@ofrei ofrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, and these are super useful changes!

@ofrei ofrei merged commit 842638d into main Dec 14, 2023
6 checks passed
@espenhgn espenhgn deleted the espenhgn/issue209 branch December 14, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrei ofrei ofrei approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@espenhgn @ofrei