Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sodium 0.5.3 and above #273

Closed
wants to merge 3 commits into from
Closed

Conversation

Obydux
Copy link

@Obydux Obydux commented Jan 28, 2024

No description provided.

@Eveeifyeve
Copy link

I would like to see that this updates to 0.5.6 because indium has issues with my mods because it below the speed of updates.

@Obydux Obydux changed the title Update to Sodium 0.5.6 Update to Sodium 0.5.6 & 0.5.7 Jan 29, 2024
@OpenBagTwo
Copy link

I succeeded in building @Obydux's branch, and in a fresh instance I was able to load the game, create a world and load a shader (Complementary 5.1.1 + Euphoria Patches).

Mod and system stack
  • Linux x86_64
  • PrismLauncher
  • AMD 5900X + AMD 6700XT
  • Minecraft 1.20.4
  • Fabric Loader 0.15.6
  • Sodium 0.5.7
  • Lithium 0.12.1
  • Iris 1.6.15
  • Sound Physics Remastered 1.20.4-1.3.1
  • ReplayMod 1.20.4-2.6.14
  • EuphoriaPatcher 0.3.0-fabric

I do have crashes when upgrading one of my existing instances to the Sodium 0.5.7 stack, but that one has far more mods, and I have no reason to expect that the issue is with Indium.

@SettingDust
Copy link

He does nothing about coding in this PR. You can just use fabric dependencies override with the latest Indium
#271 (comment)

@OpenBagTwo
Copy link

He does nothing about coding in this PR.

Is there any reason to expect that code changes are needed for the new version of Sodium? Specifically referencing:

I don't recommend this. Some glitches would hurt players with huge mod lists.

Originally posted by @DroidZed in #271 (comment)

are there known / suspected incompatibilities with the latest changes introduced by Sodium?

@DroidZed
Copy link

He does nothing about coding in this PR.

Is there any reason to expect that code changes are needed for the new version of Sodium? Specifically referencing:

I don't recommend this. Some glitches would hurt players with huge mod lists.

Originally posted by @DroidZed in #271 (comment)

are there known / suspected incompatibilities with the latest changes introduced by Sodium?

What I meant was that "some glitches" may affect the users of this mod when applying that "fix".

Ignoring the dependencies just to make the warning go away and have the game run knowing it may break or anything is not a viable solution.

@NotoriousPyro
Copy link

He does nothing about coding in this PR.

Is there any reason to expect that code changes are needed for the new version of Sodium? Specifically referencing:

I don't recommend this. Some glitches would hurt players with huge mod lists.

Originally posted by @DroidZed in #271 (comment)
are there known / suspected incompatibilities with the latest changes introduced by Sodium?

What I meant was that "some glitches" may affect the users of this mod when applying that "fix".

Ignoring the dependencies just to make the warning go away and have the game run knowing it may break or anything is not a viable solution.

Considering that's all the author of this mod did to make it compatible for 1.20.4, unless you have evidence that something is broken "visually" then we can surmise that it works given the number of people saying so, and people can report bugs if and when they happen...

@AutonomousCat
Copy link

Heads up, Sodium is on 0.5.8 now

@Obydux Obydux changed the title Update to Sodium 0.5.6 & 0.5.7 Support Sodium 0.5.3 and above Feb 2, 2024
@comp500 comp500 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants