Move s3_access_logging module reference to main.tf

companieshouse · May 3, 2024 · 1c68d2c · 1c68d2c
1 parent 53bd4e9
commit 1c68d2c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/groups/fil/main.tf b/groups/fil/main.tf
@@ -14,3 +14,17 @@ terraform {
 provider "aws" {
   region = var.region
 }
+
+####################################################################################################
+## S3 access logging
+####################################################################################################
+
+module "s3_access_logging" {
+  source = "git@github.com:companieshouse/terraform-modules//aws/s3_access_logging?ref=tags/1.0.264"
+
+  count = local.ef_presenter_data_count
+
+  aws_account           = var.aws_account
+  aws_region            = var.region
+  source_s3_bucket_name = local.ef_presenter_data_bucket_name
+}
diff --git a/groups/fil/s3.tf b/groups/fil/s3.tf
@@ -52,11 +52,3 @@ resource "aws_s3_bucket_public_access_block" "ef_presenter_data" {
   ignore_public_acls      = true
   restrict_public_buckets = true
 }
-
-module "s3_access_logging" {
-  source = "git@github.com:companieshouse/terraform-modules//aws/s3_access_logging?ref=tags/1.0.262"
-
-  aws_account         = var.aws_account
-  aws_region          = var.region
-  source_s3_bucket_id = aws_s3_bucket.ef_presenter_data.id
-}