Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

company-set-selection: adding offset internally instead of via caller #1032

Merged
merged 1 commit into from
Oct 28, 2020
Merged

company-set-selection: adding offset internally instead of via caller #1032

merged 1 commit into from
Oct 28, 2020

Conversation

kiennq
Copy link
Contributor

@kiennq kiennq commented Oct 27, 2020

Fix #1030
The selection is being offset for company-tng to work. Before we just offset it in company-select-next, that logic should be mved to company-set-selection.

@dgutov
Copy link
Member

dgutov commented Oct 28, 2020

Thanks!

@dgutov dgutov merged commit dd92593 into company-mode:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

company-tng breaks company-search-candidates
2 participants
@kiennq @dgutov