Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

company overlay goes wonky if it overlaps a folded outline #16

Closed
tsdh opened this issue Apr 24, 2013 · 4 comments
Closed

company overlay goes wonky if it overlaps a folded outline #16

tsdh opened this issue Apr 24, 2013 · 4 comments

Comments

@tsdh
Copy link

tsdh commented Apr 24, 2013

I use outline-minor-mode in almost all my source files. When the company tooltip overlay overlaps a folded outline heading, it totally gets wonky.

Here are two screenshots illustrating the problem much better than any words can do.

That's how it's supposed to look (and how it actually looks when there's no collapsed outline):

unfolded-good

Now I've collapsed the next two headline below point, and now that's what I get:

folded-bad

@dgutov
Copy link
Member

dgutov commented Apr 24, 2013

Thanks for the report.

I can reproduce the black-and-white part of the problem, but where does the [+] indicator come from? If I enable outline-minor-mode and call hide-entry, it displays ellipsis at the end of the line instead.

@tsdh
Copy link
Author

tsdh commented Apr 25, 2013

The [+] instead of the standard ellipsis is a customization of mine:

(set-display-table-slot
 standard-display-table
 'selective-display
 (let ((face-offset (* (face-id 'shadow) (lsh 1 22))))
   (vconcat (mapcar (lambda (c) (+ face-offset c)) "[+]"))))

@dgutov dgutov closed this as completed in a696ca3 Apr 26, 2013
@dgutov
Copy link
Member

dgutov commented Apr 26, 2013

That seems to do it.
The ellipsis indicator gets hidden, but I don't think there's a reasonable way to keep it, with our current approach.

@tsdh
Copy link
Author

tsdh commented Apr 26, 2013

Yes, now it works.

That the ellipsis are gone is a bit unfortunate, but really no big issue. Thanks for the quick fix, Dmity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants