Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compdemocracy/polis#1686 #1690

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

youchenlee
Copy link
Contributor

document.origin is deprecated, the value is undefined on my Chrome (114.0.5735.106).
Replaced by self.origin

@ballPointPenguin
Copy link
Contributor

Thanks for finding this. We'll test a few things and likely approve and merge soon.

Additional context: https://udn.realityripple.com/docs/Web/API/Document/origin

@ballPointPenguin
Copy link
Contributor

ballPointPenguin commented Jul 7, 2023

There are a few instances of documenet.location.origin that likely need to be updated as well.

@ballPointPenguin
Copy link
Contributor

There are a few instances of documenet.location.origin that likely need to be updated as well.

Update: It seems like document.location.origin is still probably fine
https://udn.realityripple.com/docs/Web/API/Location/origin

@ballPointPenguin
Copy link
Contributor

document.domain is also deprecated and occurs in client-report/src/util/url.js but I will update that in a different piece of work dealing with client-report generally

@ballPointPenguin ballPointPenguin merged commit 5d16072 into compdemocracy:edge Jul 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants