Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST]: LLVM-IR suggested enhancements #5062

Closed
OfekShilon opened this issue May 19, 2023 · 5 comments · Fixed by #5078
Closed

[REQUEST]: LLVM-IR suggested enhancements #5062

OfekShilon opened this issue May 19, 2023 · 5 comments · Fixed by #5078
Labels
request Request for something

Comments

@OfekShilon
Copy link
Member

OfekShilon commented May 19, 2023

Is your feature request related to a problem? Please describe

The LLVM-IR contents somewhat lag behind the shiny and new llvm-opt-pipeline view.

Describe the solution you'd like

(1) When LLVM-IR view is active, it would be helpful to build with -fno-discard-value-names. This (most of the time) preserves var names in the IR.

(2) It would be helpful to add the filter checkboxes from llvm-opt-pipeline pane, to optionally declutter the view. At least the removal of debug info is very useful.

Thanks for all your great work!

Describe alternatives you've considered

Curl up into fetal posture and cry

Additional context

Not applicable

@OfekShilon OfekShilon added the request Request for something label May 19, 2023
@OfekShilon
Copy link
Member Author

OfekShilon commented May 19, 2023

Sorry I see now that the -fno-discard is a default-on option in the opt-pipeline:
image

It would be just great just to have the same options and filters (besides 'hide inconsequential passes') on the llvm-ir display.

@jeremy-rifkin jeremy-rifkin added this to TODO in LLVM IR Tooling via automation May 19, 2023
@jeremy-rifkin
Copy link
Member

Thanks for the report, I've had in mind improving the llvm-ir pane for a while now, still on the backlog :) Filters, demangling, and -fno-discard-value-names would be good and happy to do anything else you can think of.

I'd like to rework some stuff in the backend to allow control flow graphs for llvm ir to be generated too, and when that happens we can add a button for opening a cfg pane.

@OfekShilon
Copy link
Member Author

@jeremy-rifkin that would be awesome. Perhaps it would be feasible to add data-dependency-graphs too?

@jeremy-rifkin
Copy link
Member

Data dependency graphs are a good idea, we could definitely do something like that. And for assembly too.

@jeremy-rifkin
Copy link
Member

Will divert to #1158 for data-flow / data-dependency stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Request for something
Projects
Development

Successfully merging a pull request may close this issue.

2 participants