LLVM IR pane improvements #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything holding this back from being merged? |
|
Just need to implement the options and filters on the back end, I've been slow getting back to this. Got sidetracked with some other stuff 😄 |
AbrilRBS
approved these changes
Jun 8, 2023
github-actions
bot
added
lang-hook
lang-mlir
lang-pony
lang-racket
|
Should be about there now, cc @OfekShilon. I'm not sure I'm entirely happy with the filtering choices / behavior yet |
I'm afraid I'm unable to see any difference - not on the live site nor on a local instance. Was this reverted? |
|
It hasn’t been merged into the main branch yet |
jeremy-rifkin
commented
Jun 11, 2023
|
this is now live |
This was referenced Jun 14, 2023
|
You guys are the best |
ghost
mentioned this pull request
|
@jeremy-rifkin Could it be that the symbol demangling option doesn't work yet?
|
|
Yeah, there's a caching issue (more or less). Fixed it in #5153 but haven't deployed yet. |
mattgodbolt
pushed a commit
that referenced
this pull request
Jul 22, 2023
This PR will add filtering and other output options to the LLVM IR pane   Closes #5062 Related to #5045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add filtering and other output options to the LLVM IR pane
Closes #5062
Related to #5045