[BUG]: Rust links that included the --edition flag broke with compiler overrides
#5429
Comments
ojeda
added a commit
to Rust-for-Linux/rust-for-linux.com
that referenced
this issue
Aug 28, 2023
Compiler Explorer added "Compiler Overrides" [1], which for Rust include setting by default the 2021 edition. Since `rustc` does not allow that, the old link has stopped working. Reported to Compiler Explorer at [2]. Link: compiler-explorer/compiler-explorer#5001 [1] Link: compiler-explorer/compiler-explorer#5429 [2] Reported-by: Dimitri Belopopsky <dimitri@belopopsky.com> Closes: https://rust-for-linux.zulipchat.com/#narrow/stream/288089-General/topic/CE.20link.20on.20rust-for-linux.20site/near/387667888 Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
17 tasks
fornwall
added a commit
to fornwall/advent-of-code
that referenced
this issue
Sep 5, 2023
fornwall
added a commit
to fornwall/advent-of-code
that referenced
this issue
Sep 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rust shared links that included the
--editionflag broke due to the edition being specified twice, which is not allowed byrustc:This happens because the Compiler Overrides (#5001) adds the flag too.
For instance, we had the https://godbolt.org/z/W4P36a9h9 link in the Rust for Linux page (the link is now replaced to remove the flag).
Perhaps pre-filling flags may be a way around this? i.e. since a link would provide the flags, thus the pre-filled ones would not apply (#3100, #3765).
Though, if we change the behavior now, newer links (between the two changes) may break, since now they may require the flag and they would not have it since it was before set by the compiler override. But I think it is worth it to unbreak the older links, and avoid future issues/surprises (and we could always behave differently for the links in the middle, although it may not be worth the complexity).
Reported by Dimitri Belopopsky @ShadowMitia at https://rust-for-linux.zulipchat.com/#narrow/stream/288089-General/topic/CE.20link.20on.20rust-for-linux.20site/near/387667888.
The text was updated successfully, but these errors were encountered: