Compiler overrides #5001
Merged
Compiler overrides #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
decided on just adding options in the constructor, think it's ok and a lot less complicated than adding yet another properties thing |
This was referenced Apr 30, 2023
Closed
|
|
|
Based on https://github.com/compiler-explorer/infra/actions/runs/4968591553/jobs/8891278478 The following argument parsers seem broken:
|
mattgodbolt
reviewed
May 13, 2023
| stdin: string; | ||
| }; | ||
|
|
||
| export type CompilationRequestOptions = { |
There was a problem hiding this comment.
Thanks for busting these out 👍🏻
| override updateState() { | ||
| const state = this.getCurrentState(); | ||
| this.container.setState(state); | ||
| this.compilerShared.updateState(state); |
|
now live! |
17 tasks
|
Thanks a ton for this @partouf -- very useful! |
ojeda
added a commit
to Rust-for-Linux/rust-for-linux.com
that referenced
this pull request
Aug 28, 2023
Compiler Explorer added "Compiler Overrides" [1], which for Rust include setting by default the 2021 edition. Since `rustc` does not allow that, the old link has stopped working. Reported to Compiler Explorer at [2]. Link: compiler-explorer/compiler-explorer#5001 [1] Link: compiler-explorer/compiler-explorer#5429 [2] Reported-by: Dimitri Belopopsky <dimitri@belopopsky.com> Closes: https://rust-for-linux.zulipchat.com/#narrow/stream/288089-General/topic/CE.20link.20on.20rust-for-linux.20site/near/387667888 Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Includes #4318 and #4999 and #5000
Adds:
Fixes #3765
Fixes #4151
Fixes #3154
Fixes #2724
Fixes #1966
Possible to address suggestions in #3100