Disable buttons for favorite overrides that are incompatible with the current compiler #5748
Conversation
|
I wonder if it wouldn't be better to gray them out instead with some CSS. |
DavidSpickett
force-pushed
the
favourite-incompatible
branch
from
57e579a
to
55eac2c
Compare
DavidSpickett
changed the title
|
I've done that by disabling the button instead, that way you can't click on it either. So now you've got a list of all the favourites and the one's that are interactable are the compatible ones. |
|
Given that there is no global display of favourites other than this menu, I agree that hiding them could be confusing in its own way. |
… current compiler And include a tooltip to tell the user why the button is disabled. One example would be: * You favourite TableGen's "action" override. * You then switch to GCC. * GCC doesn't support "action" so the button is shown, but is disabled. * If you go back to TableGen, "action" is now enabled again.
DavidSpickett
force-pushed
the
favourite-incompatible
branch
from
55eac2c
to
d8a239e
Compare
|
I just realised that this only checks the name of overrides not the values (some compilers might have "target", but different values for it). But if you are ok accepting it as is then great, and I will make a follow up that does that and provides a more specific tooltip for those situations. |
A followup is fine, no rush |
|
|
Sorry for the delay, this is now live |
And include a tooltip to tell the user why the button is disabled.
One example would be: