Reverse examples/plugin dependency relationship. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellout
force-pushed
the
reverse-example-plugin-dep
branch
from
62b63fb
to
b789900
Compare
|
It would be helpful for us to have this change in. |
|
I'm happy to push a version of this without the GH CI, if that'd get it merged. |
sellout
changed the title
This moves tests that depend on the plugin from concat-examples to concat-plugin. The one shortcoming, IMO, is that it requries duplicating the SMT flag.
sellout
force-pushed
the
reverse-example-plugin-dep
branch
from
b789900
to
5c86480
Compare
|
This looks good to me. @conal, any objection to us merging this one? |
|
Just rebased & merged it. |
|
Sorry I forgot about this one. Do all of the examples still build and work, including graphics (WebGL) and SMT? |
|
So |
|
(I.e. @conal, I see the comment about this in the |
|
@mikesperber Thanks. I don't remember how to test SMT, and I'm happy to assume that it'll work out fine (or doesn't matter). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves tests that depend on the plugin from concat-examples to
concat-plugin. The one shortcoming, IMO, is that it requries duplicating
the SMT flag.