Feature/min max namegenerators #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jthrilly
commented
Mar 17, 2022
jthrilly
commented
- Implements the configuration of min/max alter counts on name generator interfaces
- uses schema 7
- Includes changes to validations:
- Ported over some implementations from NC
- Ported over tests from NC
- Fixed bug related to minValue and 0 validation
|
Looks great, other than missing an error message:
|
|
Pushed a fix for the error message (and the options error message as well). I'm good with this if you are. |
rebeccamadsen
previously approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.