Remove "active" protocol concept #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…PC endpoint for creating interview
jthrilly
changed the title
mrkarimoff
reviewed
Jan 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
activeproperty of protocols to simplify some aspects of the app workflow. In particular, this enables a better flow for starting an interview.Towards this, I implemented a route handler at
/onboard/[protocolId]which accepts either POST or GET requests, which can optionally specify a participantID (with the tRPC route for creating a new interview record handling situations where no participant ID has been passed by checking if anonymous recruitment is enabled).I added a test section to the dashboard that allows onboarding strategies to be explored.