-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/participant urls #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove copy url from participants actions dropdown
for protocols view. allows for selecting which participants to export urls for for each protocol
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ected defaults to all. displays number of selected if not all
modal on participants view will be replaced with its own section
on participants view. replaced button with modal
button triggers a modal with protocol selection. once selected, the url is immediately coppied to the clipboard with a toast to let the user know that this has happened
clickable badge with url and copy button. toasts on copy success
truncate url, make entire badge component appear clickable to user using cursor pointer
improve file naming of export participation urls exported file. improve component file naming to differentiate bt export participant list and export participation urls functionalities
replaces content in anon recruitment section. modal triggered by button in the section. disabled if anon recruitment is disabled
jthrilly
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation not reviewed in any depth, but the UX is great. Nice work on these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#58 removed the "active" protocol concept. This also removed the ability to simply generate a participant URL without also having a protocol ID.
This PR adds back in the ability to generate participation URLs for participants/protocols.
Features: