Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORT] : Compatibility with angular 5+ #359

Closed
dev-fullstacktechnology opened this issue Nov 3, 2017 · 10 comments
Closed

[SUPPORT] : Compatibility with angular 5+ #359

dev-fullstacktechnology opened this issue Nov 3, 2017 · 10 comments
Milestone

Comments

@dev-fullstacktechnology
Copy link

Overview of the issue

This is general support query with compatibility with angular 5 version since it was released recently. They made many changes so I am sure someone got an issue with the new update. If you have any then please comment here.

Suggestion

It is good to pass your debug snapshot with support so we can track common issues.

@vogloblinsky
Copy link
Contributor

I will do a test tonight. I don't think it will break a lot.
I will also update to v5 the demo project.

@dev-fullstacktechnology
Copy link
Author

Sounds great to me. Maybe the only couple of minor bugs. I will also check tonight and send you a message.

@kunjan343
Copy link

I checked in by generate a project from scratch by using angular-cli v1.5 and no errors are been detected. Everything looks good.

@vogloblinsky
Copy link
Contributor

Demo project updated to Angular 5, Compodoc works fine on it.

@dev-fullstacktechnology if you have any remarks, you are welcome.

@btgoodwin
Copy link

btgoodwin commented Nov 7, 2017

Any chance you all can relax the TypeScript version requirement? The 5.0.0 release came out and @angular/compiler-cli depends on tsickle 0.24.1 which is locked to TypeScript 2.4.2. Since compodoc 1.0.4 is locked to 2.6.1, one ends up with NPM dependency errors when trying to use it with a Angular app.

I cloned compodoc 1.0.4, changed the TypeScript requirement to ^2.4.2 and ran npm install && npm run build && run test. It seems to be okay with the slightly older version.

Never mind. I flubbed that and still installed 2.6.1. When I replaced it with version 2.4.2, NPM ends in an unmet dependency from ts-simple-ast (0.86.0), which is also locked to TypeScript 2.6.1. Compodoc's tests still pass despite the minor version change in TypeScript.

@ctaepper
Copy link

ctaepper commented Nov 8, 2017

yes, angular 5 is locked to typescript@2.4.2 maybe an older ts-simple-ast not depending on typescript@2.6.1 will do the job, too?

@vogloblinsky
Copy link
Contributor

I will contact ts-simple-ast maintainer for having a explantion about this high dependency of TypeScript 2.6.x

@vogloblinsky vogloblinsky added this to the 1.0.7 milestone Dec 19, 2017
@vogloblinsky
Copy link
Contributor

Things are moving.
I have submitted a PR to ts-simple-ast to relax TypeScript dependency.
When dsherret/ts-morph#144 is closed, i will close this one too.

@vogloblinsky vogloblinsky modified the milestones: 1.0.7, 1.0.6 Dec 22, 2017
@vogloblinsky
Copy link
Contributor

dsherret/ts-morph#144 closed, version 4.2.0 of ts-simple-ast relax TypeScript version. I also downgrade the version required by Compodoc.
Coming in 1.0.6

@lock
Copy link

lock bot commented Sep 30, 2019

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. Why locking ? Having issues with the most up-to-date context.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants