Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectrum reader changes #189

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Spectrum reader changes #189

merged 4 commits into from
Feb 15, 2023

Conversation

ArthurDeclercq
Copy link
Contributor

@ArthurDeclercq ArthurDeclercq commented Feb 15, 2023 •
edited by RalfG

Fixed

  • If the precursor charge is not found in the MGF file, the charge from the PeptideRecord file is used instead.

@RalfG
Merge branch 'releases' into spectrum-reader-changes
e47555d
@RalfG
Change Spectrum property names:
ec3397f 
`precursor_charge` and `precursor_mz`
Revert not parsing precursor m/z from mzML files
@RalfG
Copy link
Member

RalfG commented Feb 15, 2023

We can change the behavior to 'always using the PeptideRecord' (which is usually the search engine-assigned charge state and
makes more sense to use) in a next release, as this PR will be part of v3.10.1.

@RalfG RalfG merged commit 0e3fe1f into releases Feb 15, 2023
@RalfG RalfG deleted the spectrum-reader-changes branch February 15, 2023 18:07
@RalfG RalfG added this to the v3.10.1 milestone Feb 15, 2023
@RalfG RalfG added the bug label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfG RalfG RalfG approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v3.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArthurDeclercq @RalfG