-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to use any version of axe core #65
Comments
It seems like npm has already solved this problem. Make Current consumers of the package should be able to continue using |
Currently, axe-core is bundled within this library, so unless we change the build setup, the peer dependency approach won't work. The proposed solution should work if we decide to keep the bundled approach. But, if we want to unbundle it; then, peer dependency should be enough. |
Now I see the problem! It's bundling all dependencies, which doesn't sound like an optimal solution: Line 13 in ca7ac69
And looks like there were reasons to bundle it though I'm not sure what exactly was the problem: |
I've done some experiments on my project that uses cypress-axe. When I try to use not bundled code, it fails with “fs.readFileSync is not a function”: However, using I suggest we make a version with |
I've opened a pull request #69 — this works perfectly in my project. Would be great if anyone else could test it too. |
Thanks, @sapegin. I'm not sure either why @avanslaars decided to bundle it. If we can unbundle it, that will be great. |
🎉 This issue has been resolved in version 0.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I see a couple of issues opened to upgrade axe core version, which is bundled in this library. (#36, #58)
To avoid this type of request in the future, I think we can make this awesome library more flexible by allowing users to use any axe core version.
I'm proposing to add a parameter to the injectAxe method, so users can specify their axe core source/version to overwrite the default version.
Sample scenario: Assuming the user wants to use the latest axe core
The text was updated successfully, but these errors were encountered: