cli: allow setting empty name in options (to infer) #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ProjectOptions` includes config to pass to the loader, but most of the fields, including `Name`, are optional. If unset/empty, the loader will determine a project name (if possible). Allow (re-)setting it to empty here. This is mostly for convenience based on the way these helpers are used in practice, so that it's possible to pass a value from e.g. a CLI flag in, which will be empty if unset. Also added a bunch of documentation to the type. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
ndeloof
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProjectOptionsincludes config to pass to the loader, but most of the fields, includingName, are optional. If unset/empty, the loader will determine a project name (if possible).Allow (re-)setting it to empty here. This is mostly for convenience based on the way these helpers are used in practice, so that it's possible to pass a value from e.g. a CLI flag in, which will be empty if unset.
Also added a bunch of documentation to the type.