introduce depends_on.service to define the target service #404
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
depends_on_service
branch
from
7fcaa23
to
db5d06c
Compare
|
Is this still relevant? If so, can we maybe think about other names for this property other than |
|
I don't feel |
laurazard
reviewed
Oct 18, 2023
Comment on lines
+402
to
+403
| database: | ||
| service: db |
There was a problem hiding this comment.
I think only having this example might be a bit confusing for new users who don't know about this feature. I'd leave this example as is, and add a specific example about the service key under it's explanation
laurazard
reviewed
Oct 18, 2023
| @@ -380,6 +380,7 @@ expressed in the short form. | |||
| to successful completion before starting a dependent service. | |||
| - `required`: When set to `false` Compose only warns you when the dependency service isn't started or available. If it's not defined | |||
| the default value of `required` is `true`. | |||
| - `service`: name of the target service (defaults to mapping key). Value can be set by a variable. | |||
|
|
|||
There was a problem hiding this comment.
(I'd add the example using this key under this line)
|
Yeah I guess you're right 😅. I left a couple comments just about examples, but otherwise LGTM |
jhrotko
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
introduce
depends_on.serviceto define target service. Defaults to mapping key, but could be overridden, typically using a variable.Which issue(s) this PR fixes:
see docker/compose#10855