Hide suggest reason when there is not one

composer · Jun 9, 2018 · 87646ae · 87646ae
1 parent 5bae191
commit 87646ae
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/Composer/Installer/SuggestedPackagesReporter.php b/src/Composer/Installer/SuggestedPackagesReporter.php
@@ -115,10 +115,10 @@ public function output(RepositoryInterface $installedRepo = null)
             }
 
             $this->io->writeError(sprintf(
-                '%s suggests installing %s (%s)',
+                '%s suggests installing %s%s',
                 $suggestion['source'],
                 $this->escapeOutput($suggestion['target']),
-                $this->escapeOutput($suggestion['reason'])
+                $this->escapeOutput('' !== $suggestion['reason'] ? ' ('.$suggestion['reason'].')' : '')
             ));
         }
 

diff --git a/tests/Composer/Test/Installer/SuggestedPackagesReporterTest.php b/tests/Composer/Test/Installer/SuggestedPackagesReporterTest.php
@@ -142,6 +142,20 @@ public function testOutput()
         $this->suggestedPackagesReporter->output();
     }
 
+    /**
+     * @covers ::output
+     */
+    public function testOutputWithNoSuggestedPackage()
+    {
+        $this->suggestedPackagesReporter->addPackage('a', 'b', '');
+
+        $this->io->expects($this->once())
+            ->method('writeError')
+            ->with('a suggests installing b');
+
+        $this->suggestedPackagesReporter->output();
+    }
+
     /**
      * @covers ::output
      */