Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer init not accepting my name (similar to issue #3948) #5631

Closed
emeraldinspirations opened this issue Aug 28, 2016 · 4 comments
Closed
Milestone

Comments

@emeraldinspirations
Copy link
Contributor

Attempting to run composer.phar init produces the following error:

Author [Matthew "Juniper" Barlett <emeraldinspirations@gmail.com>, n to skip]: 
 Invalid author string.  Must be in the format: John Smith <john@example.com> 
Author [Matthew "Juniper" Barlett <emeraldinspirations@gmail.com>, n to skip]: Matthew (Juniper) Barlett <emeraldinspirations@gmail.com>
 Invalid author string.  Must be in the format: John Smith <john@example.com> 
Author [Matthew "Juniper" Barlett <emeraldinspirations@gmail.com>, n to skip]: 

screenshot from 2016-08-28 04-13-03

@curry684
Copy link
Contributor

The regexp is at https://github.com/composer/composer/blob/master/src/Composer/Command/InitCommand.php#L323 if you want an easy PR 😉

@emeraldinspirations
Copy link
Contributor Author

emeraldinspirations commented Aug 28, 2016

I am sorry, @curry684, I am new to gitHub. What do you mean by PR? 😕

@curry684
Copy link
Contributor

https://www.thinkful.com/learn/github-pull-request-tutorial/ 😄

@emeraldinspirations
Copy link
Contributor Author

Status: Running into a circular dependency issue.

  • To run the unit tests, composer is required
  • Must fix the bug in order to install composer into the repo
  • Can't verify the bug is fixed without the unit tests

Also, while I can simply adjust the filter, I have not yet finished tracing the code in order to verify that the quote character won't cause additional issues down the line.

Seldaek pushed a commit that referenced this issue Sep 2, 2016
- Add " ( and ) as valid characters in author name
- Add relavent unit tests
@Seldaek Seldaek closed this as completed Sep 2, 2016
@Seldaek Seldaek added this to the 1.2 milestone Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants