Fix for issue #5631 #5638
Closed
Fix for issue #5631 #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add " ( and ) as valid characters in author name - Add relavent unit tests
|
LGTM |
| @@ -320,7 +320,7 @@ function ($value) use ($self, $minimumStability) { | |||
| */ | |||
| public function parseAuthorString($author) | |||
| { | |||
| if (preg_match('/^(?P<name>[- \.,\p{L}\p{N}\'’]+) <(?P<email>.+?)>$/u', $author, $match)) { | |||
| if (preg_match('/^(?P<name>[- \.,\p{L}\p{N}\'’\"\(\)]+) <(?P<email>.+?)>$/u', $author, $match)) { | |||
There was a problem hiding this comment.
You are not required to escape double quote and parentheses in "character class" (characters sequence inside square brackets). The same is actual for existing dot.
The results probably will be the same, but pattern will look less complicated.
There was a problem hiding this comment.
That is correct. It could be simplified to:
^(?P<name>[- .,\p{L}\p{N}\'’"()]+) <(?P<email>.+?)>$
|
@alcohol sorry, new to github. What does LGTM mean? P.S. is there some sort of abbreviation key somewhere? |
|
Looks good to me. :-) |
Seldaek
pushed a commit
that referenced
this pull request
Sep 2, 2016
|
Thanks, merged in 1.2 so it won't show merged here, but it's in the composer snapshots now and will be in the next 1.2.x release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer init not accepting my name (similar to issue #3948) #5631