-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow psr/log ^3.0 #10454
Allow psr/log ^3.0 #10454
Conversation
To allow psr/log 3 we'd have to add the PHP 8 type hints IIRC? |
@Seldaek true, I missed that composer/composer implements that interface as well. Not sure what is the possible upgrade path here, I guess it is not possible to support (v1+v2) and v3 at the same time as method signatures are incompatible? |
you can support v1+v2+v3 at the same time with 2 conditions:
The first condition is not met in the composer 2.2 LTS branch. |
I've changed target to master |
Same as in composer#10158
not having changes in the BaseIO class is wrong. It does not actually make it compatible with v3 (see the second condition I listed in my previous comment) |
@stof yup I did but the return types are already there 🤔 So since it was compatible till now I assume it still is. Removing |
the
indeed sorry. I looked at the wrong composer branch. |
Ok let's give this a shot, I forgot it was possible with 7.2 by ignoring the $message type. Thanks! |
Same as in #10158