Rename COMPOSER_BIN_DIR (in bin proxies) to COMPOSER_RUNTIME_BIN_DIR #10512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as env var since Composer 2.2.2) to COMPOSER_RUNTIME_BIN_DIR to fix a regression due to a name clash, fixes composer#10504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 2.2.2 due to a name clash (as COMPOSER_BIN_DIR already existed and is read by Composer's Config to override the default bin-dir parameter)
Fixes #10504
I'm open to feedback on the new name, and I still need to update the docs to clarify all this, but in principle the fix should work and as the COMPOSER_BIN_DIR var for bin proxies has been available for just over a month it's a small BC break I'm ok making.. I doubt it's in much use if at all.