GH Actions: run against PHP 8.3 #11601
Conversation
|
The test should be changed to do |
@stof Good point, my brain clearly wasn't working. I've opened PR #11602 to fix this. |
|
Happy to get a rebase here, and yes experimental false sounds ok if it builds, now that 8.3 is in RC I guess it shouldn't have surprises anymore. |
| - php-version: "8.3" | ||
| dependencies: highest-ignore | ||
| os: ubuntu-latest | ||
| experimental: true |
There was a problem hiding this comment.
Sorry these in fact should replace the 8.2 above at line 58 and 62, instead of adding new builds. And then at line 33 it needs to be added as well to get the regular locked build. That keeps the amount of builds to a reasonable-ish level. Thanks
There was a problem hiding this comment.
To reduce the needs to update, should the lowest-ignore and highest-ignore jobs use latest as PHP version ?
What with PHP 8.3 being close to the first RC, I'd like to suggest enabling runs against PHP 8.3 for the linting and test runs.
* Linting passes on PHP 8.3, so I propose to not allow new failures to be introduced there.
* The test runs, however, do not pass against PHP 8.3, so I'm marking those as `experimental` for now to allow for fixing the issue(s).
As for the compatibility issues (based on the test runs):
* PR 11599 fixes all known deprecation notices.
* There is, however, one test failure, which I'm not exactly sure how to fix, so I'm leaving this for the maintainers to decide upon.
Details:
Prior to PHP 8.3, `ReflectionMethod` could set a `private` method on a parent class to accessible. This is no longer possible in PHP 8.3 since php/php-src 9470 and breaks the `Composer\Test\Repository\ComposerRepositoryTest::testWhatProvides` test.
Also see: https://3v4l.org/8YcIk/rfc#vgit.master
* Don't add PHP 8.3 to the `lint` workflow. * Replace the PHP 8.2 extra builds instead of adding to them for `test`. * Don't allow builds to fail.
jrfnl
force-pushed
the
feature/ghactions-add-php-8.3
branch
from
eb44b39
to
2db1797
Compare
|
@Seldaek Rebased and updated. |
|
Thanks |
Re: branch selection: as Composer 2.2 is marked as an LTS release, by rights, this PR should be pulled to the 2.2 branch, but the 2.2 branch isn't even being tested against PHP 8.2, which gives me the impression that the "LTS" is only about Composer native functionality, not about PHP version support.
Might be a good idea to clarify this somewhere ?
GH Actions: run against PHP 8.3
What with PHP 8.3 being close to the first RC, I'd like to suggest enabling runs against PHP 8.3 for the linting and test runs.
experimentalfor now to allow for fixing the issue(s).As for the compatibility issues (based on the test runs):
Details:
Prior to PHP 8.3,
ReflectionMethodcould set aprivatemethod on a parent class to accessible. This is no longer possible in PHP 8.3 since ReflectionMethod constructor should not find private parent method php/php-src#9470 and breaks theComposer\Test\Repository\ComposerRepositoryTest::testWhatProvidestest.Also see: https://3v4l.org/8YcIk/rfc#vgit.master