Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More refactoring for AutoloadGenerator #2298

Closed
wants to merge 10 commits into from
Closed

More refactoring for AutoloadGenerator #2298

wants to merge 10 commits into from

Commits on Aug 1, 2013

  1. AutoloadGenerator: Most methods that depend on filesystem stuff are f… 

    …actored out into AutoloadGeneratorHelper.
    @donquixote
    donquixote committed Aug 1, 2013
    Copy the full SHA
    0c5e268 View commit details
    Browse the repository at this point in the history

  2. Methods in AutoloadGeneratorHelper now directly dump the file instead… 

    … of just creating the code.
    @donquixote
    donquixote committed Aug 1, 2013
    Copy the full SHA
    008af0c View commit details
    Browse the repository at this point in the history

  3. Move code out of dumpAutoloadRealFile().

    @donquixote
    donquixote committed Aug 1, 2013
    Copy the full SHA
    773c566 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2013

  1. Add plenty of comments in AutoloadGenerator and AutoloadGeneratorHelper.

    @benjisg @donquixote
    benjisg authored and donquixote committed Sep 27, 2013
    Copy the full SHA
    b53b992 View commit details
    Browse the repository at this point in the history

  2. Add as an explicit property in AutoloadGeneratorHelper. (It is alread… 

    …y being used in dumpAutoloadRealFile(), it just wasn't an explicit property)
    @donquixote
    donquixote committed Sep 27, 2013
    Copy the full SHA
    9c685c0 View commit details
    Browse the repository at this point in the history

  3. fold the dumping of array files into dumpArrayFile() method.

    @donquixote
    donquixote committed Sep 27, 2013
    Copy the full SHA
    caa94f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2013

  1. Refactor AutoloadGenerator: 1. Move each 'aspect' into its own class.… 

    … 2. Fight paramter madness by introducing a AutoloadGenerationTask lazy value container.
    @donquixote
    donquixote committed Sep 28, 2013
    Copy the full SHA
    5ef7631 View commit details
    Browse the repository at this point in the history

  2. fix line endings

    @donquixote
    donquixote committed Sep 28, 2013
    Copy the full SHA
    f1052d1 View commit details
    Browse the repository at this point in the history

  3. some comments added

    @donquixote
    donquixote committed Sep 28, 2013
    Copy the full SHA
    ec0fffe View commit details
    Browse the repository at this point in the history

  4. fix line endings

    @donquixote
    donquixote committed Sep 28, 2013
    Copy the full SHA
    c8c913a View commit details
    Browse the repository at this point in the history