Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Ask for target directory when using create-project #9181

Merged
merged 1 commit into from
Sep 8, 2020
Merged

✨ Ask for target directory when using create-project #9181

merged 1 commit into from
Sep 8, 2020

Conversation

shrink
Copy link
Contributor

@shrink shrink commented Sep 3, 2020

The create-project command is used by a lot of projects as part of their installation documentation, for example Symfony, Laravel and Statamic. The create-project command accepts a directory argument which authors of installation instructions must try to convey to readers as being a value the reader must replace with their desired directory.

This Pull Request is for a change to add a new ask option which allows documentation authors to remove any reference to the directory argument and instead have Composer prompt the reader for their target directory. This does not change the default behaviour.

dev:~$ composer create-project symfony/symfony --ask
New project directory [optional]:

Here are a couple of screenshots of the documentation from Symfony, Laravel and Statamic that demonstrate the problem.

Statamic:

Before

Screenshot 2020-09-03 at 18 01 25

After

Screenshot 2020-09-03 at 18 01 18

Symfony:

Screenshot 2020-09-03 at 17 46 15

Laravel:

Screenshot 2020-09-03 at 17 45 35

@shrink shrink changed the base branch from master to 1.10 September 4, 2020 13:06
@shrink shrink changed the base branch from 1.10 to master September 4, 2020 13:06
@Seldaek Seldaek added the Feature label Sep 8, 2020
@Seldaek Seldaek added this to the 2.0-core milestone Sep 8, 2020
@Seldaek Seldaek merged commit 5555b04 into composer:master Sep 8, 2020
@Seldaek
Copy link
Member

Seldaek commented Sep 8, 2020

Thanks

Seldaek added a commit that referenced this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants