Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remind "no forks, no testing" on package submission (stronger warning on fork detection) #109

Closed
simensen opened this issue Mar 6, 2012 · 2 comments

Comments

@simensen
Copy link
Contributor

simensen commented Mar 6, 2012

In order to prevent people from failing to RTFM and posting one-off forks and/or testing packages, we can provide a gentle reminder on the submit page along with a link or two. We can also say, "this is important because deleting packages is a very special case and not something we do lightly" or some such. Whatever wording makes the most sense and is not confusing. :)

We can also hook into the specialized VCS drivers (say, GitHub's) and see if we can detect whether or not the repository is authoritative or not. (i.e., if it is a GitHub fork, it is more than likely not authoritative) In this case, the follow up, "we've detected [vendor/package], si this correct?" prompt can also show a much more aggressive message like:

This package looks to be a fork of another project. Are you sure you want to add this package? Remember, we take package removal very seriously so do not add forks unless you are planning to maintain this code for a very long time. If you want to test your package, you can define a VCS repository in your composer.json file. link

This will not block forks from being submitted (as there are valid use cases where a fork makes sense) but it should hopefully give people yet one more chance to think about what they are doing.

@simensen
Copy link
Contributor Author

@Seldaek Would you say this is able to be closed with #261 deployed?

@Seldaek
Copy link
Member

Seldaek commented Dec 13, 2012

Ah yes, forgot. But yes let's close it. It's good enough, and it doesn't seem like we have a long queue of people willing to implement it better anyway ;)

@Seldaek Seldaek closed this as completed Dec 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants