phpstan-dba: improve coverage

composer.json

@@ -88,7 +88,7 @@
         "phpstan/phpstan-doctrine": "^1",
         "phpstan/phpstan-symfony": "^1.1",
         "phpunit/phpunit": "^9.5",
-        "staabm/phpstan-dba": "^0.2",
+        "staabm/phpstan-dba": "dev-main",
         "symfony/browser-kit": "^5.2",
         "symfony/css-selector": "^5.2",
         "symfony/debug-bundle": "^5.2",

phpstan-bootstrap.php

@@ -13,7 +13,7 @@
 // phpstan-dba
 $cacheFile = __DIR__.'/.phpstan-dba.cache';
 $config = new RuntimeConfiguration();
-// $config->debugMode(true);
+$config->debugMode(true);
 
 (new Dotenv())->bootEnv(__DIR__ . '/.env');
 $dsn = parse_url($_SERVER['DATABASE_URL']);

src/Command/IndexPackagesCommand.php

@@ -288,6 +288,9 @@ private function getTags(Package $package): array
         }, $tags)));
     }
 
+    /**
+     * @param int[] $idsToUpdate
+     */
     private function updateIndexedAt(array $idsToUpdate, string $time)
     {
         $retries = 5;

src/Entity/PackageRepository.php

@@ -469,6 +469,9 @@ public function getDependents(string $name, int $offset = 0, int $limit = 15, st
         return $this->getEntityManager()->getConnection()->fetchAllAssociative($sql, $args);
     }
 
+    /**
+     * @param string $name
+     */
     public function getSuggestCount($name): int
     {
         $sql = 'SELECT COUNT(*) count FROM suggester WHERE packageName = :name';
@@ -477,6 +480,11 @@ public function getSuggestCount($name): int
         return (int) $this->getEntityManager()->getConnection()->fetchOne($sql, $args);
     }
 
+    /**
+     * @param string $name
+     * @param int $offset
+     * @param int $limit
+     */
     public function getSuggests($name, $offset = 0, $limit = 15)
     {
         $sql = 'SELECT p.id, p.name, p.description, p.language, p.abandoned, p.replacementPackage

src/Entity/SecurityAdvisoryRepository.php

@@ -27,6 +27,9 @@ public function getPackageSecurityAdvisories(string $name): array
             ->fetchAllAssociative($sql, ['name' => $name]);
     }
 
+    /**
+     * @param string[] $packageNames
+     */
     public function searchSecurityAdvisories(array $packageNames, int $updatedSince): array
     {
         $sql = 'SELECT s.packagistAdvisoryId as advisoryId, s.packageName, s.remoteId, s.title, s.link, s.cve, s.affectedVersions, s.source, s.reportedAt, s.composerRepository

src/Entity/VersionRepository.php

@@ -113,6 +113,9 @@ public function detachToArray(array $versions, array $versionData, bool $seriali
         return $res;
     }
 
+    /**
+     * @param int[] $versionIds
+     */
     public function getVersionData(array $versionIds)
     {
         $links = [

src/Package/SymlinkDumper.php

@@ -104,8 +104,8 @@ public function __construct(ManagerRegistry $doctrine, Filesystem $filesystem, U
      * Dump a set of packages to the web root
      *
      * @param int[]   $packageIds
-     * @param Boolean $force
-     * @param Boolean $verbose
+     * @param boolean $force
+     * @param boolean $verbose
      */
     public function dump(array $packageIds, $force = false, $verbose = false)
     {

src/Package/Updater.php

@@ -274,11 +274,12 @@ public function update(IOInterface $io, Config $config, Package $package, VcsRep
     }
 
     /**
-     * @return array with keys:
-     *                    - updated (whether the version was updated or needs to be marked as updated)
-     *                    - id (version id, can be null for newly created versions)
-     *                    - version (normalized version from the composer package)
-     *                    - object (Version instance if it was updated)
+     * @return array{updated: true, id: int|null, version: string, object: Version}|array{updated: false, id: int|null, version: string, object: null}
+     *
+     * - updated (whether the version was updated or needs to be marked as updated)
+     * - id (version id, can be null for newly created versions)
+     * - version (normalized version from the composer package)
+     * - object (Version instance if it was updated)
      */
     private function updateInformation(IOInterface $io, VersionRepository $versionRepo, Package $package, array $existingVersions, CompletePackageInterface $data, $flags, $rootIdentifier)
     {