Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed repoUrl which links to stargazers, watchers and forks #709

Closed
wants to merge 1 commit into from

Conversation

ondrejmirtes
Copy link

I found out that the links on the package detail page sometimes lead to 404s:

https://packagist.org/packages/phpstan/phpstan:

But sometimes the URL is right:

https://packagist.org/packages/composer/composer:

I really don't know what's the underlying issue, if the URL reported by GitHub is inconsistent or what, so I tried to fix it with a conditional trimming of the .git from the end of the URL.

@Seldaek
Copy link
Member

Seldaek commented Aug 3, 2016

That's odd.. I fixed the whole DB a while back and made sure that .git URLs didn't make their way in anymore.. but it looks like that didn't quite work :) (see b0ab24b, the key is

$this->repository = $driver->getRepositoryUrl();
)

I'll keep this open as a reminder but stripping .git isn't a solution because for non-github URLs the .git might well be needed.

@Seldaek
Copy link
Member

Seldaek commented Aug 3, 2016

As a fix for your package though, just change the URL to be the https://github.com/foo/bar URL and all will be fine.

@Seldaek Seldaek closed this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants