Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #772

Merged
merged 2 commits into from Mar 6, 2017
Merged

Update README.md #772

merged 2 commits into from Mar 6, 2017

Conversation

vitman
Copy link
Contributor

@vitman vitman commented Mar 2, 2017

added one more step to run packagist

5. Run `app/console assets:install web` to deploy the assets on the web dir.
6. Make a VirtualHost with DocumentRoot pointing to web/
6. Run `app/console cache:warmup --env=prod` and `app/console cache:warmup --env=prod` to warmup cache
7. Make a VirtualHost with DocumentRoot pointing to web/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing this to

-7. Make a VirtualHost with DocumentRoot pointing to web/
+7. Make a VirtualHost with DocumentRoot pointing to `web/`.

Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -17,9 +17,9 @@ Installation
1. Clone the repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about squashing the commits into a single commit?

@Seldaek Seldaek merged commit bf173b3 into composer:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants