Fix MultiConstraint optimization with version overlap #121
Conversation
jderusse
force-pushed
the
optimize-multi2
branch
from
c244343
to
a6264ff
Compare
jderusse
force-pushed
the
optimize-multi2
branch
from
a6264ff
to
2977d5b
Compare
| default: | ||
| continue 3; | ||
| } | ||
| } |
There was a problem hiding this comment.
Not against doing this, but I think some comments would be good here :)
Why !/>/= and !/</= are OK and the rest not?
I see how != is fine to optimize as that's a single gap in the range.
But I don't see why == is ok to optimize, ^1.0 || ^2.0, =2.0.3 means ^1.0 || 2.0.3 but with this optimization it'd become 1.0 - 3.0, 2.0.3 which is only matched by 2.0.3. The ^1.0 is dropped.
I am also not sure why </> are ok in each respective loop. ^1.0 <1.1 || ^2.0 > 2.0.4 getting merged to 1.0 - 3.0, <1.1, > 2.0.4 also seems wrong to me as this suddenly cannot match anything anymore.
So all in all this seems broken, except for != which can be safely kept, but then the question is it worth looping over things just in the odd case we have a !=, which is anyway quite rare..
There was a problem hiding this comment.
yeah.. you're right, I missed to much cases... let's close this
This is an alternative fix for d07997a#commitcomment-44111784