Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the behaviour of Utf8 to replicate that of strict Text #1386
base: master
Are you sure you want to change the base?
Extend the behaviour of Utf8 to replicate that of strict Text #1386
Changes from all commits
2cb75c3
56a045a
d8a5a76
bd4c051
95fe359
d606c34
25b84fc
a419c5c
a5492cd
2cb9aa1
119633a
4c467cc
e71127a
426a52d
74e1280
464a444
9c0cde5
eb3d9f1
7ecb533
d8a0897
9bce2f5
98e4400
6af34fa
07c248a
a651995
09c7288
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use something like this:
streamly/src/Streamly/Internal/Data/Array/Stream/Foreign.hs
Line 131 in 3cba8fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to use stream based implementation instead of using list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use identity monad instead of unsafePerformIO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using snoc may not be most efficient, we should implement it in a streaming way, see unlines in Unicode.Stream module.